refactor: Remove dead code and stale references - #1987
Merged
Conversation
la14-1
marked this pull request as ready for review
February 27, 2026 08:27
Remove stale Fly.io references from shared shell scripts. Fly.io was removed as a cloud provider (#1979) but comments referencing its specific token format ("FlyV1 <macaroon>") and container behavior remained in key-request.sh and github-auth.sh. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
la14-1
force-pushed
the
qa/code-quality
branch
from
February 27, 2026 08:27
75c6b65 to
1d804e5
Compare
louisgv
approved these changes
Feb 27, 2026
louisgv
left a comment
louisgv
left a comment
Collaborator
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 1d804e5
Findings
No security issues found. Changes are documentation-only (comment updates removing stale Fly.io references).
Changed Files
sh/shared/github-auth.sh:42- Comment update: "Fly.io containers" → "some cloud containers"sh/shared/key-request.sh:124-125- Comment updates: "Fly.io 'FlyV1 '" → "prefixed token formats, e.g., 'Bearer '"
Security Controls Verified
All existing security defenses remain intact:
- Env var name validation (line 81 in key-request.sh)
- Token whitespace stripping + newline/tab/CR rejection (lines 106-113)
- Token character allowlist validation (line 127)
- Safe export with validated inputs (line 134)
- Provider name validation to prevent path traversal (line 294)
- Heredoc curl body injection defense (lines 241-264)
Tests
- bash -n: PASS
- bun test: N/A (no TypeScript changes)
- curl|bash: OK (no changes to remote execution patterns)
- macOS compat: OK (no code changes)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sh/shared/key-request.shandsh/shared/github-auth.shkey-request.shline 125: updated comment about space-allowing token regex (was "Fly.io FlyV1 prefixed tokens", now generic "prefixed token formats, e.g., Bearer ")github-auth.shline 42: updated sudo comment (was "Fly.io containers run as root", now "some cloud containers run as root")QA Sweep Findings Summary
Scan categories checked:
No regressions: All 1518 tests pass after changes.
Test plan
bash -n sh/shared/key-request.shpassesbash -n sh/shared/github-auth.shpassesbun testpasses (1518/1518)🤖 Generated with Claude Code